Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose HIPE: Anoncreds protocol #109

Merged
merged 61 commits into from Jun 20, 2019
Merged

Conversation

brentzundel
Copy link
Member

This HIPE is a description of the cryptography used in the anoncreds protocol as it is currently implemented.

brentzundel and others added 30 commits January 25, 2019 10:22
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
mikelodder7 and others added 19 commits February 1, 2019 09:31
Signed-off-by: Michael Lodder <redmike7@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Brent <brent.zundel@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
perspective:
* the issuer gives a credential *C* based on identity schema *X*,
which asserts certain properties 𝒫 about *X*, to the holder.
* The credential consists of attributes represented by integers
Copy link
Member

@jovfer jovfer Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this HIPE reference or cover topic around user-friendly attributes vs integers for math?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like how the sdk encodes the user-friendly attributes into integers?

Copy link
Member

@jovfer jovfer Apr 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. In my mind this HIPE should mention, that we have 2 representations of attributes and math operates only with integers.
and libindy allow to use application encoding (from initial raw representation to integer) and doesn't check anything vs libvcx use hashing to automatically encode non-integer attribs.

I'm not sure should this HIPE cover a lot of details, but I think we have to describe at least two types and point out, that mathematics proof can confirm only integers and it's up to application/library above libursa & libindy to check validity of encoding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a section in d464b93. Please let me know if it addresses your concerns, or if you feel more should be added.

@brentzundel brentzundel changed the title Anoncreds protocol propose HIPE: Anoncreds protocol Apr 19, 2019
@dhh1128
Copy link
Member

dhh1128 commented Jun 20, 2019

@brentzundel and @ken-ebert : I have raised a PR against your PR to add a HIPE number and status section to your README.md. See brentzundel#15. Please merge my PR. Once you do, this PR can be merged. We are now following a streamlined process; see the updated description in the repo's /README.md.

@dhh1128 dhh1128 merged commit f452222 into hyperledger:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants