avoid unneccessary base64 encode of protected data for tag computation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
kdenhartog
reviewed
Apr 12, 2019
| 3. base64URLencode the `protected` value | ||
| 4. encrypt the message using libsodium.crypto_aead_chacha20poly1305_ietf_encrypt_detached(message, protected_value_encoded, iv, cek) this is the ciphertext. | ||
| 3. set `protected` to base64 of the JSON array from step 2. | ||
| 4. encrypt the message using libsodium.crypto_aead_chacha20poly1305_ietf_encrypt_detached(message, JSON from step 2, iv, cek) this is the ciphertext. |
There was a problem hiding this comment.
If I'm reading this properly, your proposal is to pass the bytes of JSON into the AAD? If so I believe this will make the tag unverifiable because JSON doesn't have deterministically serialize and deserialize, which I believe is necessary for the AAD operation. Am I reading this wrong?
|
I think this PR should be closed. It moves us away from the JWE standard and I don't believe it garnered enough efficiency worth accepting it. I believe this is why @lovesh closed the PR that referenced this. |
|
This has been superseded by a slightly modified technique that uses out-of-the-box JWE/JWS features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lovesh harchandani lovesh.bond@gmail.com