Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose HIPE: Error reporting #65

Closed
wants to merge 24 commits into from
Closed

Conversation

swcurran
Copy link
Member

@swcurran swcurran commented Dec 3, 2018

A HIPE that proposes a new message type ("problem-report") for handling some categories of errors, and provides recommendations on the handling of a broad range of error categories, including the timeouts.

swcurran and others added 12 commits September 24, 2018 21:47
Signed-off-by: Stephen Curran <swcuran@gmail.com>
Signed-off-by: Stephen Curran <swcuran@gmail.com>
Signed-off-by: Stephen Curran <swcuran@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
minor tweaks to make some verbiage clearer
Signed-off-by: Stephen Curran <swcurran@gmail.com>
}
```

### Fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting the field list into Required Fields and Optional Fields would make the flexibility of this message type more clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TelegramSam - not clear on how you would split it. Could you please expound? We presumably wouldn't want "required" and "optional" JSON objects. Or is that the suggestion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, just splitting up the list in the documentation. No actual changes to the JSON at all.

@dhh1128 dhh1128 changed the title Propose HIPE: Error handling Propose HIPE: Error reporting Dec 27, 2018
@TelegramSam
Copy link
Contributor

I feel like there should be an error code field. There is a code for the human-readable error, but not necessarily a top-level attribute with a code that can be specified in a message family and matched when processing the error message.

dhh1128 and others added 6 commits January 30, 2019 17:48
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@dhh1128
Copy link
Member

dhh1128 commented May 28, 2019

This is now superseded by Aries RFC 0035: hyperledger/aries-rfcs#35

@dhh1128 dhh1128 closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants