Gha Refactoring #1738
Merged
Gha Refactoring #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pSchlarb
force-pushed
the
GHARefactoring
branch
from
d6640ed
to
b58ecb2
Compare
WadeBarnes
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Overall looks great, and will be easier to maintain.
- Please rename
build-push-and pr.yamltopush_pr.yamlto be consistent with the changes made in Plenum. - Update the readme file in the workflows directory, most of it is not relevant anymore.
- Plus have a look at the suggestion below
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
WadeBarnes
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builddockerimage, testing, package building and publishing part has been outsourced with the reusable workflows.