INDY-1881: Catchup clearing #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ashcherbakov
reviewed
Dec 3, 2018
ashcherbakov
reviewed
Dec 3, 2018
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ashcherbakov
reviewed
Dec 4, 2018
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ArtObr
commented
Dec 4, 2018
ArtObr
commented
Dec 4, 2018
ashcherbakov
reviewed
Dec 5, 2018
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
| looper.run(eventually(node_caughtup, behind_node, count, retryWait=1)) | ||
|
|
||
| assert len(behind_node.requests) == req_num | ||
| assert all(r.executed for r in behind_node.requests.values() if behind_node.seqNoDB.get(r.request.key)[1]) |
There was a problem hiding this comment.
Should we expect that the request is removed from resuests (and all other queues) at all?
There was a problem hiding this comment.
No, because of backup replicas. I will create two separate tests for this
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
plenum/test/batching_3pc/catch-up/test_clearing_requests_after_catchup.py
Outdated
Show resolved
Hide resolved
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ashcherbakov
reviewed
Dec 5, 2018
|
|
||
| looper.run(eventually(node_caughtup, behind_node, count, retryWait=1)) | ||
|
|
||
| assert all(r.executed and r.forwardedTo == 0 for r in behind_node.requests.values()) |
There was a problem hiding this comment.
Why can't we check that requests queue (as well as queue in re_authenticator and all replicas) is empty?
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ashcherbakov
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArtObr artemobruchnikov@gmail.com