INDY-1866: Fix memory leak #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
ashcherbakov
reviewed
Dec 6, 2018
|
|
||
| # Make sure that verified req list is empty | ||
| for node in txnPoolNodeSet: | ||
| assert len(node.clientAuthNr._verified_reqs) == 0 |
There was a problem hiding this comment.
Should we use authNr instead of clientAuthNr?
There was a problem hiding this comment.
In order to use authNr we need a Request object which we don't have here. While we can exploit the fact that authNr returns clientAuthNr unconditionally and pass some garbage I believe it's more clear just to use clientAuthNr directly, at least for now.
|
|
||
| # Let last node catch up | ||
| # TODO: Change to some more sensible wait condition | ||
| looper.runFor(5.0) |
There was a problem hiding this comment.
ensure_all_nodes_have_same_data?
There was a problem hiding this comment.
Not sure if this is actually needed in this test
|
|
||
| # Let last node catch up | ||
| # TODO: Change to some more sensible wait condition | ||
| looper.runFor(5.0) |
There was a problem hiding this comment.
It would be great to check that Propgates have been actually received for the ordered request.
added 3 commits
December 6, 2018 12:08
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
ashcherbakov
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com