INDY-1836: clear monitor data related to dropped request. #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2018 15:53
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
plenum/server/monitor.py
Outdated
| if key in self._unordered: | ||
| self._unordered.discard(key) | ||
| if key in self._handled_unordered: | ||
| self._handled_unordered.discard(key) |
There was a problem hiding this comment.
When discarding some value from set there is no need to check that it was here in the first place
There was a problem hiding this comment.
I believe that checking that force_req_drop doesn't break anything inside RequestTracker is done by test_req_drop_* group of tests that call this function in a various stages of request processing and then check that pool is functional.
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
skhoroshavin
approved these changes
Dec 17, 2018
ashcherbakov
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Shilov sergey.shilov@dsr-company.com