INDY-1836: add test of req drop when replica does not order. #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a new counter unordered_by_replicas_num for req_state to check how many replicas have not yet ordered particular request. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
|
Can one of the admins verify this patch? |
| @@ -81,6 +82,15 @@ def forwarded(self, req: Request) -> bool: | |||
| """ | |||
| return self[req.key].forwarded | |||
|
|
|||
| def ordered_by_replica(self, request_key): | |||
There was a problem hiding this comment.
I think this also needs to be called in the following cases:
_clear_request_for_txnclear_requests_and_fix_last_ordered
| @@ -81,6 +82,15 @@ def forwarded(self, req: Request) -> bool: | |||
| """ | |||
| return self[req.key].forwarded | |||
|
|
|||
| def ordered_by_replica(self, request_key): | |||
There was a problem hiding this comment.
Please add/extend tests for this new method
| @@ -81,6 +82,15 @@ def forwarded(self, req: Request) -> bool: | |||
| """ | |||
| return self[req.key].forwarded | |||
|
|
|||
| def ordered_by_replica(self, request_key): | |||
There was a problem hiding this comment.
Should we call this mark_as_ordered to be aligned with mark_as_executed and mark_as_forwarded?
There was a problem hiding this comment.
It is a manipulation with a counter, so such renaming is not fully correct semantically.
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
ashcherbakov
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a new counter unordered_by_replicas_num for req_state
to check how many replicas have not yet ordered particular
request.
Signed-off-by: Sergey Shilov sergey.shilov@dsr-company.com