[INDY-1876] Integration ReplicaStasher and ReplicaValidator #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…plenum into task-1876-ordering-in-catchup
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
TODO: Fix fixtures in replica tests Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-1876-ordering-in-catchup
plenum/server/replica.py
Outdated
| def on_catch_up_finished(self, last_caught_up_3PC=None): | ||
| if self.isMaster: | ||
| if last_caught_up_3PC is None: | ||
| self.looger.info("{} - on_catch_up_finished needs " |
| @@ -50,13 +50,13 @@ def test_non_primary_recvs_3phase_message_outside_watermarks( | |||
| slowNode.nodeIbStasher.delay(chk_delay(300)) | |||
|
|
|||
| initialDomainLedgerSize = slowNode.domainLedger.size | |||
| oldStashCount = slowReplica.spylog.count(TestReplica.stashOutsideWatermarks.__name__) | |||
There was a problem hiding this comment.
I think it's better to check for slowReplica.stasher.num_stashed_watermarks
| @@ -43,8 +43,9 @@ def testNodeDiscardMessageFromUnknownView(txnPoolNodeSet, | |||
| # 3 pc msg (PrePrepare) needs to be discarded | |||
| _, did = sdk_wallet_client | |||
| primaryRepl = getPrimaryReplica(txnPoolNodeSet) | |||
| inst_id = 0 | |||
| three_pc = PrePrepare( | |||
There was a problem hiding this comment.
Can we use a helper method create_pre_prepare for creation of PrePrepare?
[WIP][INDY-1876] Integration ReplicaStasher and ReplicaValidator
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
TODO: Fix fixtures in replica tests Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
…plenum into task-1876-ordering-in-catchup
…plenum into task-1876-ordering-in-catchup
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…ktar/indy-plenum into task-1876-ordering-in-catchup
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-1876-ordering-in-catchup
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
| extra={'cli': True}) | ||
| self.mode = Mode.synced | ||
|
|
||
| need_up_and_clear = compare_3PC_keys(self.master_last_ordered_3PC, |
There was a problem hiding this comment.
Why can't we do this check inside on_catch_up_finished?
There was a problem hiding this comment.
Because if we check it inside then firstly updated master replica and backups can't updated backups after, master_last_ordered_3PC will already be changed.
There was a problem hiding this comment.
We can revert replicas list for this "for" but it looks like an unobvious way.
There was a problem hiding this comment.
well, but we can just pass master_last_ordered_3PC then
ashcherbakov
approved these changes
Jan 11, 2019
ashcherbakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone: ashcherbakov#1