-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INDY-1949: Add more logging #1056
INDY-1949: Add more logging #1056
Conversation
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-1876-ordering-in-catchup
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
plenum/server/replica.py
Outdated
self.logger.debug("Queueing commit due to unavailability of PREPARE. " | ||
"Request {} from {}".format(request, sender)) | ||
self.logger.info("Queueing commit due to unavailability of PREPARE. " | ||
"Request {} from {}".format(request, sender)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, that we shoud add "key" into log string, for checking equality of key and value in the commitsWaitingForPrepare map ((key should be equal to (request.viewNo, request.ppSeqNo)))
plenum/server/replica.py
Outdated
self.logger.debug("{} queueing prepare due to unavailability of PRE-PREPARE. " | ||
"Prepare {} from {}".format(self, pMsg, sender)) | ||
self.logger.info("{} queueing prepare due to unavailability of PRE-PREPARE. " | ||
"Prepare {} from {}".format(self, pMsg, sender)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, that we shoud add "key" into log string, for checking equality of key and value in the preparesWaitingForPrePrepare map (key should be equal to (request.viewNo, request.ppSeqNo))
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Add logging for a while. Return after solving the task INDY-1949.