INDY-1955: add REPLICA_STASH_LIMIT to config #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
plenum/config.py
Outdated
| @@ -384,3 +384,6 @@ | |||
|
|
|||
| # It's count of freshness updates for checking Has_write_consensus in validator-info | |||
| ACCEPTABLE_FRESHNESS_INTERVALS_COUNT = 2 | |||
|
|
|||
| # Limit for numbers of 3pc and checkpoint messages stashed in replica | |||
| REPLICA_STASH_LIMIT = 1000 | |||
There was a problem hiding this comment.
I'm totally fine with moving it to config, but not sure that the value needs to be 1000.
If we have 25 nodes pool, then we got ~50 3PC messages per batch. So, only 20 3PC batches can be stashed, which is just 20 seconds of work.
I think a catch-up can take more than 20 secs for sure.
If we don't stash all, then the node will not be able to order again, so the whole purpose of stashing doesn't make sense.
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
previously approved these changes
Jan 30, 2019
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toktar renata.toktar@dsr-corporation.com