Simulation test for ViewChanger #1095
Conversation
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
…ough Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
|
||
| @st.composite | ||
| def pool_model_events(draw, node_count): | ||
| greek_names = ['Alpha', 'Beta', 'Gamma', 'Delta', 'Epsilon', 'Zeta', 'Eta', 'Theta'] |
There was a problem hiding this comment.
BTW we already have greek.py helper methods
There was a problem hiding this comment.
I felt like we have something like this, and I tried to find it, but failed. Thanks for finally pointing where it is located!
|
|
||
| settings.register_profile("big", buffer_size=128 * 1024, max_examples=1000) | ||
| settings.load_profile("big") | ||
|
|
There was a problem hiding this comment.
I would separate into separate modules
- helper (events-models) classes
- tests for helper classes
- real property based tests (like this file)
, so that it's clear what property tests we have, and what files need to executed.
There was a problem hiding this comment.
Agreed, although if at some point in future we get approval to add Hypothesis as test dependency then this can be reduced to just two separate modules:
- simulation helper classes
- tests for simulation helper classes
And real simulation tests can be put next to other tests related to tested part of production code
|
|
||
| @staticmethod | ||
| def _sort_nodes(nodes: Tuple[str, str]): | ||
| if nodes[0] > nodes[1]: |
There was a problem hiding this comment.
Do we intentionally compare two strings here? Why do we need to do this sort?
There was a problem hiding this comment.
Yes, this is intentional. If we have nodes A and B we don't want to store whether they have connectivity or not separately for A-B and B-A. This is solved nicely by sorting tuples before accessing underlying dictionary.
No description provided.