INDY-1945: Implement CatchupRepGatherer #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 1, 2019 17:13
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
…atchupRepGatherer Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
reviewed
Mar 4, 2019
|
|
||
| class LedgerManager(HasActionQueue): | ||
| CatchupGatherer = NamedTuple('CatchupGatherer', |
There was a problem hiding this comment.
I would prefer to call it CatchupRepProcessor or CatchupRepService
| self._provider.notify_lm_catchup_start(self._ledger_id) | ||
| self._provider.notify_li_before_catchup_start(self._ledger_id) | ||
|
|
||
| def _gen_catchup_reqs_from_cons_proof(self, cons_proof: ConsistencyProof): |
There was a problem hiding this comment.
Do we really need this method? It looks like we've already did a check for the number of eligible nodes right before calling it.
There was a problem hiding this comment.
I'm also not sure if we really need this, but I kept original logic for extra safety.
ashcherbakov
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.