[INDY-1992] Adds base classes to support versioning routine #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
…-1992-versioning-base
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
ashcherbakov
reviewed
Mar 5, 2019
|
|
||
| max_length = 20 | ||
| legacy_validator = VersionField(components_number=(2, 3,), max_length=max_length) | ||
| validator = VersionField(version_cls=VersionTestCls, max_length=max_length) |
There was a problem hiding this comment.
But legacy validation also uses DigitDotVersion, so is it intentional that we validate by the same Version Validator?
Should we also parametrize using SemVerReleaseVersion?
| ) | ||
|
|
||
|
|
||
| def test_version_base_abstracts(version_base_required): |
There was a problem hiding this comment.
What do we test by this test? Why don't we instantiate real instances of Version classes instead of dealing with Abstracts and class internals?
ashcherbakov
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
packaging==19.0to support PEP440 (PyPI versioning)