[WIP][INDY-2010] add command GET_AUTH_RULE #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-add-command-get-auth-rule
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
|
||
| # Do not inline please, it makes debugging easier | ||
| return result | ||
| multi_sig = self.bls_store.get(encoded_root_hash) |
There was a problem hiding this comment.
Why can't we move this calculation to base method? The only source of multi-sig is bls_store , so it looks like quite generic logic.
There was a problem hiding this comment.
PoolReqHandler doesn't work with a bls_store, therefore, the bls_store and work with it were not moved to the LedgerRequestHandler. But I think this is not so important, we can move it.
There was a problem hiding this comment.
I think it would be great to move it there, but this is fine to do it latter.
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.