INDY-1945: Minor catchup improvements #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2019 17:22
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
force-pushed
the
indy-1945-11
branch
from
19e43fe
to
13bff2b
Compare
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| @@ -141,8 +141,8 @@ def test_3pc_while_catchup_with_chkpoints_only(tdir, tconf, | |||
| ) | |||
|
|
|||
| # check that catch-up was started twice | |||
| assert lagging_node.spylog.count(Node.allLedgersCaughtUp) == initial_all_ledgers_caught_up + 2 | |||
| assert lagging_node.spylog.count(Node.start_catchup) == 2 | |||
| assert lagging_node.spylog.count(Node.allLedgersCaughtUp) == initial_all_ledgers_caught_up + 1 | |||
There was a problem hiding this comment.
Why is it 1 again? I think this is because we delay LEDGER_STATUSs and CATCHUP_REPLYs for the first ledger, which is Pool now, so we get Checkpoints before we actually start catching up Audit ledger. So, we catch-up all the txns in Audit (and hence Domain), and this is not what we want to test.
Please make sure that we delay catchup msgs for Audit or Domain ledgers, so that we catchup less.
Also please make sure that other tests from this folder are OK.
skhoroshavin
changed the title
ashcherbakov
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.