INDY-1757: Double digest validation implemented #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
| assert len(idrs) == 1 | ||
| assert req_obj1.digest in idrs | ||
|
|
||
|
|
There was a problem hiding this comment.
It would also be great to have the following tests:
- Make the Primary malicious, so that it sends already ordered requests (with the same full signature). Make sure that other nodes do not process such requests and initiate a view change.
- Make the Primary malicious, so that it sends already ordered requests (with a different full signature). Make sure that other nodes do not process such requests and initiate a view change.
- Have 2 reqs with the same payload but different signatures. Have 2 nodes having one version of the request propagated, and 2 nodes having a different version. Make sure that only one version of the request is ordered on all nodes, and all nodes have equal ledgers.
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
|
Approving, but please process existing comment, and add test #3. |
ashcherbakov
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArtObr artemobruchnikov@gmail.com