INDY-1863: Allow limiting maximum number of 3PC batches in flight #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2019 19:23
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| # Send a number of requests | ||
| reqs = sdk_send_random_requests(looper, sdk_pool_handle, sdk_wallet_client, BATCHES_TO_ORDER) | ||
|
|
||
| # Continuously check number of batches in flight |
There was a problem hiding this comment.
Why don't have more deterministic test, for example delay COMMITs, and make sure that the number of created PrePrepares is not more than MAX_BATCHES_IN_FLIGHT? Then start processing delayed commits one by one.
There was a problem hiding this comment.
Great idea, thanks!
| if self.replica.viewNo == self.replica.last_ordered_3pc[0]: | ||
| if self.replica.lastPrePrepareSeqNo < self.replica.last_ordered_3pc[1]: | ||
| return False | ||
| if self.replica.config.Max3PCBatchesInFlight is not None: |
There was a problem hiding this comment.
Please add unit tests to test_replica_3pc_validation.py
| if self.replica.viewNo == self.replica.last_ordered_3pc[0]: | ||
| if self.replica.lastPrePrepareSeqNo < self.replica.last_ordered_3pc[1]: | ||
| return False | ||
| if self.replica.config.Max3PCBatchesInFlight is not None: |
There was a problem hiding this comment.
Please add a comment why this check is inside self.replica.viewNo == self.replica.last_ordered_3pc[0] (as I understand, this is to avoid issues after view change to send enough batches when we have ppSeqNo=1).
added 4 commits
April 15, 2019 13:41
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com