Do not check freshness in a catchup. #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -754,4 +754,5 @@ def propose_view_change(self, suspicion=Suspicions.PRIMARY_DEGRADED): | |||
|
|
|||
| def is_state_fresh_enough(self): | |||
| threshold = self.config.ACCEPTABLE_FRESHNESS_INTERVALS_COUNT * self.config.STATE_FRESHNESS_UPDATE_INTERVAL | |||
| return self.provider.state_freshness() < threshold | |||
| return self.provider.state_freshness() < threshold or (not self.view_change_in_progress and | |||
There was a problem hiding this comment.
Should we require participating mode only?
| @@ -754,4 +754,5 @@ def propose_view_change(self, suspicion=Suspicions.PRIMARY_DEGRADED): | |||
|
|
|||
| def is_state_fresh_enough(self): | |||
| threshold = self.config.ACCEPTABLE_FRESHNESS_INTERVALS_COUNT * self.config.STATE_FRESHNESS_UPDATE_INTERVAL | |||
| return self.provider.state_freshness() < threshold | |||
| return self.provider.state_freshness() < threshold or (not self.view_change_in_progress and | |||
There was a problem hiding this comment.
I think the condition would be much more readable if write as follows:
if self.provider.state_freshness() < threshold:
return True
if not self.view_change_in_progress and self.provider.node_mode() != Mode.participating:
return True
return False
| tconf, ): | ||
| """ | ||
| Check that InstanceChange with reason "State signatures are not updated for too long" | ||
| are not sends in catchup without view change. |
| lagging_node.start_catchup() | ||
| looper.runFor(tconf.ACCEPTABLE_FRESHNESS_INTERVALS_COUNT * tconf.STATE_FRESHNESS_UPDATE_INTERVAL + 5) | ||
|
|
||
| print(lagging_node.view_changer.instance_changes._cache) |
There was a problem hiding this comment.
Please remove the print
ashcherbakov
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toktar renata.toktar@dsr-corporation.com