INDY-2053: Fix one more edge case in catch up #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2019 13:51
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
reviewed
May 7, 2019
| ensure_all_nodes_have_same_data(looper, normal_nodes, custom_timeout=30) | ||
|
|
||
| # Make sure that we will receive cons proof from lagging node before all other nodes | ||
| start_delaying(normal_stashers, lsDelay(delay=0.5)) |
There was a problem hiding this comment.
Should we have more explicit check, that we received ConsProofs from all the nodes?
There was a problem hiding this comment.
I don't think we need such check because:
- we don't actually want to wait for cons proofs from ALL nodes
- all we care about is that we receive cons proof from lagging node before normal nodes, so it is not discarded if normal nodes provide quorum of equal cons proofs faster
ashcherbakov
previously approved these changes
May 7, 2019
ashcherbakov
previously approved these changes
May 7, 2019
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.