[INDY-2066] Adds more taa data to state #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
…-2066-taa-ts-in-state Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
…-2066-taa-ts-in-state Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
skhoroshavin
previously approved these changes
May 14, 2019
| digest = taa_digests[data.version] | ||
|
|
||
| config_req_handler.update_txn_author_agreement(*data) | ||
| written.append(data.version) |
There was a problem hiding this comment.
Feels like this test contains too much logic compared to original one with just two examples.
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
Signed-off-by: Andrey Kononykhin <andkononykhin@gmail.com>
andkononykhin
force-pushed
the
INDY-2066-taa-ts-in-state
branch
from
a8b26cb
to
061b00d
Compare
ashcherbakov
approved these changes
May 15, 2019
| assert _digest is None | ||
| assert _data is None | ||
|
|
||
| for data in taa_input_data: |
There was a problem hiding this comment.
This is of course a matter of taste, and not a subject for change, but I would prefer more simple and readable unit tests (closer to the initial version of the tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.