INDY-2067: Implement GET_TXN_AUTHOR_AGREEMENT #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 14, 2019 17:41
…EEMENT Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
…EMENT Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
|
||
| # TODO: Change txnPoolNodeSet to nodeSetWithOneNodeResponding after | ||
| # correct state proof checking is implemented in Indy SDK | ||
| def test_state_proof_returned_for_get_txn_author_agreement( |
There was a problem hiding this comment.
I think we need to have multiple tests (and hence multiple sdk_get_txn_author_agreement) for each variant of GET_TAA: latest, by digest, by ts.
There was a problem hiding this comment.
Of course they are planned. Also tests checking for consistency proofs for absent keys are planned as well.
added 3 commits
May 15, 2019 13:35
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
added 3 commits
May 15, 2019 17:16
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
May 15, 2019
| @@ -75,6 +76,15 @@ class ClientTxnAuthorAgreementOperation(MessageValidator): | |||
| ) | |||
|
|
|||
|
|
|||
| # TODO: Add more fields along with implementation | |||
| class ClientGetTxnAuthorAgreementOperation(MessageValidator): | |||
There was a problem hiding this comment.
I believe we need a specific validation that either GET_TXN_AUTHOR_AGREEMENT_VERSION or GET_TXN_AUTHOR_AGREEMENT_DIGEST can be specified, not both.
There was a problem hiding this comment.
Thanks for pointing at it
|
Looks good, so I think we can merge it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.