INDY-2097: update pluggable request handlers #1221
Conversation
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
| @@ -52,9 +52,8 @@ def update_state(self, txn, prev_result, is_committed=False): | |||
| """ | |||
| pass | |||
|
|
|||
| @abstractmethod | |||
| def gen_state_key(self, txn): | |||
There was a problem hiding this comment.
I think we need to keep this method and use it as the main (primary) key in the state.
It needs to be abstract, so that every req handler must implement it.
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-2097-update-pluggable-handlers
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
changed the title
| from plenum.server.request_handlers.utils import is_trustee | ||
|
|
||
| MARKER_TAA = "2" | ||
| MARKER_TAA_AML = "3" |
There was a problem hiding this comment.
please, move it into separate module with constants in the next PR.
There was a problem hiding this comment.
I would move every marker (for a txn type) into the corresponding WriteReqHandler.
Corresponding read req handlers (for this txn type) can get it from WriteReqHandlers (static method or constant).
plenum/test/req_handler/test_get_txn_author_agreement_aml_handler.py
Outdated
Show resolved
Hide resolved
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-2097-update-pluggable-handlers
Toktar
changed the title
| from plenum.server.request_handlers.utils import is_trustee | ||
|
|
||
| MARKER_TAA = "2" | ||
| MARKER_TAA_AML = "3" |
There was a problem hiding this comment.
I would move every marker (for a txn type) into the corresponding WriteReqHandler.
Corresponding read req handlers (for this txn type) can get it from WriteReqHandlers (static method or constant).
Signed-off-by: toktar renata.toktar@dsr-corporation.com