Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INDY-2108: Write request manager tests #1238

Merged
merged 3 commits into from
Jun 14, 2019
Merged

INDY-2108: Write request manager tests #1238

merged 3 commits into from
Jun 14, 2019

Conversation

ArtObr
Copy link
Contributor

@ArtObr ArtObr commented Jun 11, 2019

No description provided.

@ArtObr
INDY-2108:Write request manager tests
3545032 
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
@ArtObr
Merge remote-tracking branch 'base/master' into database_tests
6432a86
@ArtObr
INDY-2108: Fix tests
b910945 
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ashcherbakov
ashcherbakov reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@ashcherbakov ashcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following needs to be changed in WriteRequestManager:

  • rename post_batch_rejected to post_reject_batch
  • commit_batch can use three_pc_batch as an input parameter

@ashcherbakov ashcherbakov merged commit 9acbbc5 into hyperledger:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcherbakov ashcherbakov ashcherbakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArtObr @ashcherbakov