INDY-1338: Design interfaces for ViewChangeService + PoC simulation tests #1242
Conversation
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
plenum/common/event_bus.py
Outdated
| def subscribe(self, message_type: Type, handler: Callable): | ||
| self._handlers[message_type].append(handler) | ||
|
|
||
| def send(self, *args): |
There was a problem hiding this comment.
Should we make the first parameter (message) explicit here?
| def __init__(self): | ||
| self._handlers = defaultdict(list) # type: Dict[Type, List[Callable]] | ||
|
|
||
| def subscribe(self, message_type: Type, handler: Callable): |
There was a problem hiding this comment.
Should we define the interface for subscribers (observers)?
There was a problem hiding this comment.
I don't think so. In this generic case interface is as simple as callable accepting arbitrary parameters. The only limitation is that these parameters should match those passed to send
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
skhoroshavin
changed the title
| return [] | ||
|
|
||
| @property | ||
| def prepared(self) -> List[PrePrepare]: |
There was a problem hiding this comment.
Please add comments describing what these properties mean.
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| prepared = [] | ||
| preprepared = [] | ||
|
|
||
| self._data.view_no += 1 |
There was a problem hiding this comment.
I think we will need to store the view we are changing from to use it for 3PC messages from the previous view we are going to re-order.
There was a problem hiding this comment.
I think having NewView with PrePrepares from previous view would be enough. Furthermore, having a previous view_no won't do us any good since we might need to reorder batches from different previous views.
| from plenum.test.simulation.sim_random import SimRandom, DefaultSimRandom | ||
|
|
||
|
|
||
| class ReplicaService: |
There was a problem hiding this comment.
Why is it in test module? Should it be a production code?
No description provided.