INDY-1338: View change design updates and Plenum 2.0 Architcture diagrams #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashcherbakov
commented
Jun 20, 2019
ashcherbakov
commented
- Updates of PBFT View Change design with recent thinking and implementation plans
- Plenum 2.0 Architecture Descriptions (it's required to properly implement PBFT View Change protocol)
- Plenum 2.0 Architecture Diagrams
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
skhoroshavin
approved these changes
Jun 20, 2019
| - The flag is set to TRUE once view change is started (and viewNo +=1) | ||
| - The flag is set to FALSE once a valid NEW_VIEW is received | ||
|
|
||
| - There needs to be `last_prep_cert` field in ConsensusDataProvider: (last_view_no, prep_cert_pp_seq_no) |
There was a problem hiding this comment.
What would happen if there are two view changes in a row, with some old batches still not finished and some new batches slipping in between?
There was a problem hiding this comment.
How new batches can slip in between if we require a strict order of PrePrepares and apply them in this order only? Also we don't apply a NEW_VIEW (and the corresponding PrePrepares) if NEW_VIEW is not valid (doesn't have all PrePrepares for the last_prep_cert).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.