INDY-2157: TAA acceptance use date #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
changed the title
|
test this please |
…nto story-2157-taa-time
Toktar
changed the title
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
changed the title
|
test this please |
lampkin-diet
reviewed
Jul 8, 2019
plenum/test/txn_author_agreement/acceptance/test_taa_acceptance_validation.py
Outdated
Show resolved
Hide resolved
plenum/test/txn_author_agreement/acceptance/test_taa_acceptance_validation.py
Outdated
Show resolved
Hide resolved
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
lampkin-diet
approved these changes
Jul 8, 2019
ashcherbakov
approved these changes
Jul 9, 2019
| if datetime_r_taa.time() != time(0): | ||
| raise InvalidClientTaaAcceptanceError( | ||
| request.identifier, request.reqId, | ||
| "TAA timestamp {} is too precise and is a privacy risk." |
There was a problem hiding this comment.
I think it would be more clear to have the following error message (to be more consistent with other error messages):
Txn Author Agreement acceptance time {} is too precise and is a privacy risk.
There was a problem hiding this comment.
Will be changed in #1263
| max_last_accepted_pre_prepare_time + | ||
| randint(0, tconf.TXN_AUTHOR_AGREEMENT_ACCEPTANCE_TIME_AFTER_PP_TIME) | ||
| ) | ||
| pp_time = max_last_accepted_pre_prepare_time |
There was a problem hiding this comment.
Why did we remove adding the delta here?
There was a problem hiding this comment.
Because it is the addition of randomness to the test as a small time shift. Now we use the date and this is impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toktar renata.toktar@dsr-corporation.com