ST-601 -- add randomized test for removal of keys from the state #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2019 18:37
Signed-off-by: Nikita Khateev <nikita.khateev@dsr-corporation.com>
Signed-off-by: Nikita Khateev <nikita.khateev@dsr-corporation.com>
ashcherbakov
reviewed
Jul 9, 2019
| assert val == int(state.get(key.encode(), isCommitted=False).decode()) | ||
| state.remove(key.encode()) | ||
| else: | ||
| state.set(key.encode(), str(val).encode()) |
There was a problem hiding this comment.
Do we intentionally override existing key here?
There was a problem hiding this comment.
We generate a new key while we generating data for test. This key differs from a key that is in state.
state/test/test_remove_from_trie.py
Outdated
|
|
||
| @pytest.fixture() | ||
| def rand(): | ||
| return random.randint(0, 1000) |
There was a problem hiding this comment.
Why do we need random here? Why don't we always deal with 1000 key-value pairs?
| state.remove(key.encode()) | ||
| else: | ||
| state.set(key.encode(), str(val).encode()) | ||
| for key, val in data: |
There was a problem hiding this comment.
I think we need to check that removed values are not found in state
| sequence, data = sequence | ||
| for action, key, val in sequence: | ||
| if action: | ||
| assert val == int(state.get(key.encode(), isCommitted=False).decode()) |
There was a problem hiding this comment.
In this test we never commit. It would be great to test both committed and uncommitted cases, that is (randomly) commit values, and make sure that remove still works.
added 3 commits
August 1, 2019 16:35
Signed-off-by: Nikita Khateev <nikita.khateev@dsr-corporation.com>
Signed-off-by: Nikita Khateev <nikita.khateev@dsr-corporation.com>
ashcherbakov
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Khateev nikita.khateev@dsr-corporation.com