[WIP] INDY-1340: Checkpointer cleanups #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2019 14:02
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
force-pushed
the
indy-2177
branch
from
b8188e4
to
209e7f1
Compare
| @@ -288,6 +302,30 @@ def _checkpoint_key(checkpoint: Checkpoint) -> CheckpointKey: | |||
| digest=checkpoint.digest | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _audit_seq_no_from_3pc_key(audit_ledger: Ledger, view_no: int, pp_seq_no: int) -> int: | |||
There was a problem hiding this comment.
I would rename it to _get_committed_audit_seq_no_from_3pc_key
| seq_no -= 1 | ||
| return seq_no | ||
|
|
||
| def _audit_txn_root_hash(self, view_no: int, pp_seq_no: int) -> Optional[str]: |
There was a problem hiding this comment.
I would rename it to _committed_audit_txn_root_hash
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
force-pushed
the
indy-2177
branch
from
1821dda
to
38e4e0f
Compare
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
force-pushed
the
indy-2177
branch
from
174781c
to
b110516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.