INDY-1340: request missing old view PrePrepares when applying NewView #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
ashcherbakov
requested review from
lampkin-diet,
skhoroshavin and
Toktar
as code owners
| if result != PROCESS: | ||
| return result, reason | ||
|
|
||
| for pp_dict in msg.preprepares: |
There was a problem hiding this comment.
Should we check the order of received preprepares? It's can help with reducing "missing Pre-Prepare" requests.
There was a problem hiding this comment.
Since we use lists (not dicts) in OldViewPrePrepareRequest and OldViewPrePrepareReply, the order of PPs will be preserved.
Please have a look at test_send_reply_on_old_view_pre_prepares_request and test_process_preprepare_on_old_view_pre_prepares_reply where we make sure that result is in expected order
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
lampkin-diet
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashcherbakov alexander.sherbakov@dsr-corporation.com