-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INDY-2223: add more sim tests #1349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
… into public/indy-2223-first-step Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…tinDSR/indy-plenum into public/indy-2223-first-step Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…tinDSR/indy-plenum into public/indy-2223-first-step Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…imaries Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…nto public/indy-2223-first-step Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
requested review from
lampkin-diet,
ashcherbakov and
skhoroshavin
as code owners
September 25, 2019 09:55
…tinDSR/indy-plenum into public/indy-2223-first-step Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
check_view_change_completes_under_normal_conditions(random) | ||
@pytest.fixture(params=[(0, 0.6), (1, 2)]) | ||
def set_latency(pool_committed, request, tconf): | ||
min, max = tuple(int(param * tconf.NEW_VIEW_TIMEOUT) for param in request.param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min and max are reserved words (functions), so it's better to not use them as variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
changed the title
[WIP][ci skip][INDY-2223] add more sim tests
INDY-2223: add more sim tests
Sep 25, 2019
test this please |
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
…tinDSR/indy-plenum into public/indy-2223-first-step
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
approved these changes
Sep 25, 2019
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.