[INDY-2230] do not send NewView msg if primary is behind #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
lampkin-diet
requested review from
ashcherbakov,
skhoroshavin and
Toktar
as code owners
ashcherbakov
reviewed
Oct 9, 2019
| customTimeout=2 * tconf.NEW_VIEW_TIMEOUT) | ||
|
|
||
| assert next_primary_name != expected_primary_name | ||
| assert checkViewNoForNodes(txnPoolNodeSet) == initial_view_no + 2 |
There was a problem hiding this comment.
I think it makes sense to check that the pool can continue ordering
added 2 commits
October 9, 2019 19:03
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
ashcherbakov
approved these changes
Oct 10, 2019
skhoroshavin
approved these changes
Oct 10, 2019
| def _service(name): | ||
| data = consensus_data(name) | ||
| digest = cp_digest(DEFAULT_STABLE_CHKP) | ||
| cp = Checkpoint(instId=0, viewNo=initial_view_no, seqNoStart=0, seqNoEnd=DEFAULT_STABLE_CHKP, digest=digest) | ||
| data.checkpoints.append(cp) |
There was a problem hiding this comment.
Why do we just add new checkpoint, but not update stable checkpoint? Was it intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin andrew.nikitin@dsr-corporation.com