INDY-2244: New flags to disable batching and message requests #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashcherbakov
commented
Oct 22, 2019
ashcherbakov
commented
- add flags to disable Transport Batching and Message Requests
- bump libindy
- increase Node-to-Node message quota
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
ashcherbakov
requested review from
lampkin-diet,
skhoroshavin and
Toktar
as code owners
skhoroshavin
previously approved these changes
Oct 22, 2019
| @@ -413,3 +413,10 @@ | |||
| TXN_AUTHOR_AGREEMENT_ACCEPTANCE_TIME_AFTER_PP_TIME = 120 | |||
|
|
|||
| NEW_VIEW_TIMEOUT = 30 # in secs | |||
|
|
|||
| # Flags | |||
| TRANSPORT_BATCH_ENABLED = True | |||
There was a problem hiding this comment.
I have a suspicion that this flag needs to be placed in stp_core config...
There was a problem hiding this comment.
Currently Batching logic is in Plenum, not ZMQ...
lampkin-diet
previously approved these changes
Oct 22, 2019
skhoroshavin
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.