[INDY-2289]: Additional tests #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemqe
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
Signed-off-by: Nemanja Patrnogic <3052405+donqui@users.noreply.github.com>
| assert len(alpha._stashed_to_disconnected) == 0 | ||
| assert len(beta._stashed_unknown_remote_msgs) == len(sent_msgs) | ||
| for index, item in enumerate(sent_msgs): | ||
| assert item == beta._stashed_unknown_remote_msgs[index][0] |
There was a problem hiding this comment.
Can we check, that item was sent from alpha? Does _stashed_unknown_remote_msgs include this information? If i understood correctly if beta is not connected to alpha we can use only public key as alpha's marker.
There was a problem hiding this comment.
I added it, take a look and tell me if it is an appropriate way to do this.
Signed-off-by: Nemanja Patrnogic <3052405+donqui@users.noreply.github.com>
lampkin-diet
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nemanja Patrnogic 3052405+donqui@users.noreply.github.com