[INDY_2306]: Remove size limit for outbound msgs #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemqe
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
nemqe
force-pushed
the
feature/INDY_2306
branch
3 times, most recently
from
7150441
to
727a119
Compare
| def check_received(value): | ||
| assert beta_msg_handler.receivedMsgCount == value | ||
|
|
||
| msg_value_len = MSG_LEN_LIMIT - len("{'k':''}") |
There was a problem hiding this comment.
I think, that we need to synchronize template {'k':''} and template which makes msg, {'k': 'v'}. I mean count of whitespaces and value. As i understand, this test needs for showing that we allow messages with size more then MSG_LEN_LIMIT. Maybe we should simplify this case for checking message with serialized length more and less then MSG_LEN_LIMIT?
I mean, that we can use parameterized fixture which return whole message with serialized length less and more then MSG_LEN_LIMIT.
There was a problem hiding this comment.
made some changes, hopefully it makes more sense now...
nemqe
force-pushed
the
feature/INDY_2306
branch
from
727a119
to
9b708b9
Compare
Signed-off-by: Nemanja Patrnogic <3052405+donqui@users.noreply.github.com>
nemqe
force-pushed
the
feature/INDY_2306
branch
from
9b708b9
to
e2221c0
Compare
lampkin-diet
approved these changes
Dec 10, 2019
nemqe
changed the title
skhoroshavin
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nemanja Patrnogic 3052405+donqui@users.noreply.github.com