INDY-2324: Improvements in SimNetwork #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2020 21:08
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
requested review from
lampkin-diet,
ashcherbakov and
Toktar
as code owners
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
Jan 20, 2020
| return _selector | ||
|
|
||
|
|
||
| class ProcessingChain: |
There was a problem hiding this comment.
It would be great to have unit tests for this
There was a problem hiding this comment.
Fully agree, however part of this was already indirectly tested through legacy interface
| if not all(selector(msg, frm, dst) for selector in p.selectors): | ||
| continue | ||
|
|
||
| if isinstance(p.action, Discard): |
There was a problem hiding this comment.
It may make sense to follow chain-of-responsibility pattern more formally (have a Handler interface so that every processor implements it) to avoid isinstance checks.
There was a problem hiding this comment.
I agree that having isinstance checks is often an anti-pattern, however implementing full chain-of-responsibility looked like an overkill for this simple use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.