[INDY-2330] Tool for checking zmq connection #1471
Conversation
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
lampkin-diet
requested review from
ashcherbakov,
skhoroshavin and
Toktar
as code owners
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
scripts/test_zmq/setup.py
Outdated
| packages=find_packages(), | ||
| package_data={'': ['*.md']}, | ||
| include_package_data=True, | ||
| install_requires=['libnacl==1.6.1', 'base58==1.0.0'], |
There was a problem hiding this comment.
Do we need to install libnacl explicitly? Do we need both python3-nacl (in the Docker file) and libnacl?
There was a problem hiding this comment.
I think, that Dockerfile needs only for demonstration purposes. But in general, maybe python3-nacl is enough.
scripts/test_zmq/test_zmq/server.py
Outdated
| parser.add_argument('--tcp_port', help="Port which will be used for TCP client's connections") | ||
| args = parser.parse_args() | ||
|
|
||
| zmq_server_ha = HA('0.0.0.0', int(args.zmq_port) if args.zmq_port else '9999') |
There was a problem hiding this comment.
We may not always bind to 0.0.0.0 in production cases
There was a problem hiding this comment.
Agree, I will add option for choosing bind address and keep '0.0.0.0' as default.
scripts/test_zmq/test_zmq/server.py
Outdated
| s.bind(server_ha) | ||
| s.listen() | ||
| print("TCP_SERVER: Listen clients on {}".format(server_ha)) | ||
| while True and not QUIT: |
There was a problem hiding this comment.
It looks like QUIT is always False, isn't it?
There was a problem hiding this comment.
I forgot to remove it. It was some experiments need for demo.
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
|
|
||
| # Client | ||
| As a client this tool has the next required input parameters: | ||
| `` |
There was a problem hiding this comment.
Please user ``` instead of ``
| `` | ||
| `--zmq` and `--tcp` options are required, because they need to determine address/port tuple for remote connection for tcp and zmq protocols. | ||
| Also, it's important to make sure that both of protocols are acceptable to create connection between two nodes. | ||
| `address` - it's IP address of node which will be used to run this script as `server`. |
|
|
||
| # Example | ||
| Let client's machine will be `10.0.0.1` and server's `10.0.0.2` IP addresses. In this case, for checking connections we can run server as: | ||
| `` |
There was a problem hiding this comment.
Please user ``` instead of ``
| `--addr` parameter is optional and define IP address for binding. '0.0.0.0' will be used by default. | ||
|
|
||
| # Example | ||
| Let client's machine will be `10.0.0.1` and server's `10.0.0.2` IP addresses. In this case, for checking connections we can run server as: |
There was a problem hiding this comment.
| Let client's machine will be `10.0.0.1` and server's `10.0.0.2` IP addresses. In this case, for checking connections we can run server as: | |
| Let client's machine IP address be `10.0.0.1` and server's machine IP address be `10.0.0.2`. In this case, for checking connections we can run the server as: |
|
|
||
| if [ ! -d $V_DIR/$V_NAME ]; then | ||
| virtualenv $V_NAME | ||
| $V_DIR/$V_NAME/bin/pip install /tmp/test_zmq/dist/plenum-zmq-check-1.0.0.tar.gz |
There was a problem hiding this comment.
Why /tmp/test_zmq/dist/plenum-zmq-check-1.0.0.tar.gz?
| check_zmq.sh client '--zmq 10.0.0.2:9999 --tcp 10.0.0.2:10000' | ||
| `` | ||
|
|
||
|
|
There was a problem hiding this comment.
Please mention what this script will do so that's this is not a surprise that it installs virtualenv.
There was a problem hiding this comment.
Ok. I'll add some comments regarding requirements for installation too, like python3, pip3, etc...
Signed-off-by: Andrew Nikitin andrew.nikitin@dsr-corporation.com