INDY-2338: support generic way for request payload version #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-corporation.com>
ashcherbakov
requested review from
lampkin-diet,
skhoroshavin and
Toktar
as code owners
skhoroshavin
approved these changes
Feb 19, 2020
|
|
||
| custom_version = '3000' | ||
| if request.param == 'custom_version': | ||
| op['ver'] = custom_version |
There was a problem hiding this comment.
Suggested change
| op['ver'] = custom_version | |
| op[OP_VER] = custom_version |
There was a problem hiding this comment.
I think it makes sense to use real values (not constant variables) in tests when checking expected value to protect against accidental renaming.
In this particular I agree, that this is rather not the output to be checked, but the input, so it's better to use constants for input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashcherbakov alexander.sherbakov@dsr-corporation.com