Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions CI workflow #1513

Merged
merged 8 commits into from
Feb 25, 2021
Merged

Conversation

WadeBarnes
Copy link
Member

ToDo:

  • Clean up logging around plenum slice tests.
  • Management and publication of the build container.
  • Document what Jenkins Pipeline(s) are replaced by the new GHA workflows.

m00sey and others added 8 commits February 19, 2021 12:30
Signed-off-by: m00sey <griffin.kev@gmail.com>
- Split up plenum testing steps into slices to match Jenkins pipeline.
- Update `python3-indy` version to eliminate dependency errors.

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
- Ensure all image repository references are all lowercase.
- Document important workflow steps.
- Update workflow setup documentation.

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
- Update test runner (`runner.py`) to automatically report the test results for each set of tests.
- Update the CI workflow
  - Make it easier to slice up the plenum tests into smaller chunks.
  - Fix an out of memory error with test report publishing when there are thousands of tests.
  - Update `scacap/action-surefire-report` version
  - Collect the detailed test failure results created by `runner.py` as an artifact so it can be easily reviewed.

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
- To indicate which Jenkins pipelines are replaced by the new workflow.

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
…ainer.

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
@WadeBarnes
Copy link
Member Author

(ci) test this please.

Copy link
Contributor

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryjones ryjones enabled auto-merge (rebase) February 21, 2021 14:23
@WadeBarnes
Copy link
Member Author

@Toktar, We just need a Code Owner's approval on this PR to get it merged. Thanks

# to be in lowercase.
GITHUB_REPOSITORY_NAME: ${{ steps.cache.outputs.GITHUB_REPOSITORY_NAME }}
steps:
- name: Git checkout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need checkout here as fas as I see

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, one of the steps does a hash on some files.

.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
runner.py Show resolved Hide resolved
Copy link
Member

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway looks great!

@ryjones ryjones merged commit d98582c into hyperledger:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants