check if record.message exists with hasattr or use record.msg #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Smith <devinleighsmith@gmail.com>
|
Can one of the admins verify this patch? |
|
according to https://docs.python.org/3/library/logging.html#logging.LogRecord only .msg is supported by the logRecord spec, so I'm not sure how .message is being populated in plenum normally. |
|
(ci) test this please |
1 similar comment
|
(ci) test this please |
|
hmm, looks like the jenkins tests passed by the GH actions failed? |
WadeBarnes
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Devin Smith devinleighsmith@gmail.com