Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runner to be compatible with python 3.8, pytest 6.2.2 #1530

Merged

Conversation

devinleighsmith
Copy link
Contributor

Signed-off-by: Devin Smith devinleighsmith@gmail.com

bringing visibility to test failures in the 20.04 build of indy-plenum.

see https://github.com/devinleighsmith/indy-plenum/actions/runs/731553669 to view the test failures.

Signed-off-by: Devin Smith <devinleighsmith@gmail.com>
@sovbot
Copy link
Contributor

sovbot commented Apr 9, 2021

Can one of the admins verify this patch?

@@ -20,7 +20,7 @@ def run(pytest, output_file, repeatUntilFailure, testDir, test_slice):
log("Is going to repeat the test suite until failure")
log("Preparing test suite with {}".format(pytest))
testListFile = "test_list.txt"
collect_status = os.system('{} --collect-only {} > {}'.format(pytest, testDir, testListFile))
collect_status = os.system('python3 -m pytest -q --collect-only {} > {}'.format(testDir, testListFile))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous version of this script was not compatible with the pytest updates from the 20.04 branch, no tests would ever be found.

Signed-off-by: Devin Smith <devinleighsmith@gmail.com>
@WadeBarnes
Copy link
Member

@devinleighsmith, We've introduced some DCO issues that need to be fixed.

WadeBarnes and others added 2 commits April 12, 2021 10:30
- Update test runner (`runner.py`) to automatically report the test results for each set of tests.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
Signed-off-by: Devin Smith <devinleighsmith@gmail.com>
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this so we can get the build and lint images built the the test running under GHA. Subsequent iterations will have to revisit the dependencies that have been pinned to older versions in order to get things to work (based on this document https://github.com/hyperledger/indy-plenum/blob/ubuntu-20.04-upgrade/dev-setup/ubuntu/ubuntu-2004/SetupVMTest.txt). The goal is to upgrade to recent supported versions of the dependencies.

@WadeBarnes WadeBarnes merged commit 1839d8c into hyperledger:ubuntu-20.04-upgrade Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants