Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04: remove pip imports in favor if importlib_metadata #1550

Conversation

udosson
Copy link
Contributor

@udosson udosson commented Jul 20, 2021

This PR solves issue #1549. The PR just applies the adjustments made by @andrewwhitehead in this commit to the ubuntu-20.04-upgrade feature branch. Thanks to @andrewwhitehead for his contribution.

@udosson udosson requested a review from a team as a code owner July 20, 2021 16:23
@sovbot
Copy link
Contributor

sovbot commented Jul 20, 2021

Can one of the admins verify this patch?

@udosson udosson changed the title remove pip imports in favor if importlib_metadata Ubuntu 20.04: remove pip imports in favor if importlib_metadata Jul 20, 2021
@udosson udosson force-pushed the remove_pip_pin_ubuntu_20.04 branch from 164c156 to ffd05e3 Compare July 20, 2021 16:26
@WadeBarnes
Copy link
Member

@udosson, You'd be better off either merging the changes from master, or cherry picking @andrewwhitehead's commit from master, otherwise this is going to cause a merge conflict when we go to merge the ubuntu-20.04-upgrade branch into master in the future, since it's the exact same changes made on a different commit.

andrewwhitehead and others added 2 commits July 22, 2021 18:23
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: udosson <r.klemens@yahoo.de>
@udosson udosson force-pushed the remove_pip_pin_ubuntu_20.04 branch from ffd05e3 to e788b4a Compare July 22, 2021 16:25
@udosson
Copy link
Contributor Author

udosson commented Jul 22, 2021

@WadeBarnes thanks for your suggestion. Does the current commit history meet your recommendation?

@WadeBarnes WadeBarnes merged commit 3e72fd0 into hyperledger:ubuntu-20.04-upgrade Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants