New Release Workflow

[pSchlarb]

hyperledger/indy-shared-gha#4 needs to be merged first for this PR to work.

[sovbot]

Can one of the admins verify this patch?

[WadeBarnes]

Looks good, just a few small suggestions. I'm also going to test on my fork.

[WadeBarnes]

@pSchlarb, The following workflows have a very similar set of jobs, PR.yaml, Push.yaml, and releasepr.yaml. I think releasepr.yaml is different enough to stand on its own. PR.yaml and Push.yaml are almost identical though. I can also see why we want to keep them separate. I'm wondering whether is makes sense to turn the workflow-setup, lint, build-docker-image, plenum_tests, and build_packages into a reusable workflow that could be used by both. On its own in PR.yaml, and in combination with publish_artifacts in Push.yaml.

Do you think it's worth the extra effort at this point or should we mark it as a ToDo for the first time that "common" flow needs to be updated? I'm leaning toward the YAGNI approach and marking it as a ToDo.

[WadeBarnes]

Ran into some dependency issues with ./bump_version.sh. Needed to install a few more minimal dependencies for it to work.

[WadeBarnes]

We don't want the workflow attempting to publish packages when it's running in someone's fork, since it will always fail.

[WadeBarnes]

We need to protect against publishing in forks here too.

[pSchlarb]

@pSchlarb, The following workflows have a very similar set of jobs, PR.yaml, Push.yaml, and releasepr.yaml. I think releasepr.yaml is different enough to stand on its own. PR.yaml and Push.yaml are almost identical though. I can also see why we want to keep them separate. I'm wondering whether is makes sense to turn the workflow-setup, lint, build-docker-image, plenum_tests, and build_packages into a reusable workflow that could be used by both. On its own in PR.yaml, and in combination with publish_artifacts in Push.yaml.

The Problem with that idea is that Github doesn't allow subsequent workflow calls.
I would leave at is, since it is totally clear and the duplication doesn't hurt in the case here imho.

[WadeBarnes]

Looks like a line in one of the workflows was inadvertently duplicated.

[WadeBarnes]

Duplicate line. I think that was meant to be something like if: needs.release-infos.outputs.isVersionBump == 'true' && needs.release-infos.outputs.publish == 'true'