[INDY-992] Move bls tests to sdk #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ArtObr
changed the title
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
…t_state_proof; problem with wrong bls keys Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
…te_proof test Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ArtObr
changed the title
|
Test this please |
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
dsurnin
suggested changes
Mar 16, 2018
plenum/test/bls/helper.py
Outdated
| from common.serializers.serialization import state_roots_serializer | ||
| from plenum.common.constants import DOMAIN_LEDGER_ID, ALIAS, BLS_KEY | ||
| from crypto.bls.bls_crypto import BlsCryptoVerifier | ||
|
|
There was a problem hiding this comment.
remove empty lines between imports
plenum/test/bls/helper.py
Outdated
| None, None, | ||
| bls_key=key_in_txn, | ||
| services=None) | ||
| waitNodeDataEquality(looper, node, *txnPoolNodeSet[:-1]) |
There was a problem hiding this comment.
you pass some node to the func, it could be any node from txnPoolNodeSet, but to check equality you exclude always the last one.
I think you need to exclude the node you pass to func but not the last one
plenum/test/bls/helper.py
Outdated
|
|
||
| def validate_proof(result): | ||
| """ | ||
| Validates state proof |
plenum/test/bls/helper.py
Outdated
| def validate_proof(result): | ||
| """ | ||
| Validates state proof | ||
| """ |
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
|
Test this please |
1 similar comment
|
Test this please |
dsurnin
approved these changes
Mar 19, 2018
ashcherbakov
approved these changes
Mar 19, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* Initial test integration Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Two more files done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * new test Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * 4 more folders done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * two more files Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * some changes Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * More tests integrated. Problems: validator functions of client in test_state_proof; problem with wrong bls keys Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Script fix. bls validation fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * little fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Fix for bls validation tests. Not done: update_incorrect test and state_proof test Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Only state_proof test left Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Tests integration done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Import deletion. flake8 error fix. Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Review fixes Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Little fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* Initial test integration Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Two more files done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * new test Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * 4 more folders done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * two more files Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * some changes Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * More tests integrated. Problems: validator functions of client in test_state_proof; problem with wrong bls keys Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Script fix. bls validation fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * little fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Fix for bls validation tests. Not done: update_incorrect test and state_proof test Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Only state_proof test left Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Tests integration done Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Import deletion. flake8 error fix. Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Review fixes Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Little fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArtObr artemobruchnikov@gmail.com