[INDY-1137] Making proof possible for given root hash #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
plenum/server/domain_req_handler.py
Outdated
| @@ -162,7 +162,7 @@ def getNymDetails(state, nym, isCommitted: bool=True): | |||
| def nym_to_state_key(nym: str) -> bytes: | |||
| return sha256(nym.encode()).digest() | |||
|
|
|||
| def make_proof(self, path): | |||
| def make_proof(self, path, headHash=None): | |||
There was a problem hiding this comment.
Please use snake case
plenum/server/domain_req_handler.py
Outdated
| @@ -162,7 +162,7 @@ def getNymDetails(state, nym, isCommitted: bool=True): | |||
| def nym_to_state_key(nym: str) -> bytes: | |||
| return sha256(nym.encode()).digest() | |||
|
|
|||
| def make_proof(self, path): | |||
| def make_proof(self, path, headHash=None): | |||
There was a problem hiding this comment.
Please add a test for this
added 2 commits
March 16, 2018 17:02
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
ashcherbakov
approved these changes
Mar 19, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* [INDY-1137] Making proof possible for given root hash Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com> * [INDY-1137] Change make_proof Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com> * [INDY-1137] Added test for make_proof Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* [INDY-1137] Making proof possible for given root hash Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com> * [INDY-1137] Change make_proof Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com> * [INDY-1137] Added test for make_proof Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin andrew.nikitin@dsr-corporation.com