[INDY-1237] Get rid of RegistryPoolManager #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
dsurnin
suggested changes
Mar 28, 2018
plenum/server/pool_manager.py
Outdated
| @@ -95,14 +94,9 @@ def get_name_by_rank(self, rank, nodeReg=None) -> Optional[str]: | |||
| class HasPoolManager: | |||
| # noinspection PyUnresolvedReferences, PyTypeChecker | |||
| def __init__(self, nodeRegistry=None, ha=None, cliname=None, cliha=None): | |||
There was a problem hiding this comment.
Do we still need nodeRegistry func param?
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
…INDY-1237 Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
|
Test this please |
| @@ -28,7 +28,8 @@ def cli2(cliLooper, tdir, tdirWithClientPoolTxns, | |||
| cli.close() | |||
|
|
|||
|
|
|||
| def testEachClientOnDifferentPort(cli1, cli2): | |||
| @pytest.mark.skip(reason='node registry removal') | |||
| def testEachClientOnDifferentPort(cli1, cli2, txnPoolNodeSet): | |||
There was a problem hiding this comment.
I think these tests can be removed
| @@ -32,6 +32,7 @@ | |||
|
|
|||
|
|
|||
| # noinspection PyIncorrectDocstring | |||
| @pytest.mark.skip(reason='get rid of registry pool') | |||
| def testClientShouldNotBeAbleToConnectToNodesNodeStack(pool): | |||
There was a problem hiding this comment.
I think this test can be removed
| @@ -54,6 +55,7 @@ def testClientShouldNotBeAbleToConnectToNodesNodeStack(pool): | |||
|
|
|||
|
|
|||
| # noinspection PyIncorrectDocstring | |||
| @pytest.mark.skip(reason='get rid of registry pool') | |||
| def testSendRequestWithoutSignatureFails(pool): | |||
There was a problem hiding this comment.
I think we need a similar test based on SDK to check that we handle missing signatures properly
|
|
||
| def test_req_id_key_error(testNode, wallet1): | ||
| @pytest.mark.skip(reason='test changed in INDY-1029') | ||
| def test_req_id_key_error(looper, txnPoolNodeSetNotStarted, wallet1): |
There was a problem hiding this comment.
I don't see any sense in this test...
| @@ -105,6 +109,7 @@ def testPluginManagerSendMessageUponSuspiciousSpike( | |||
| assert sent == 3 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason='get rid of registry pool') | |||
There was a problem hiding this comment.
We can not skip this test, it's needed.
| @@ -126,6 +131,7 @@ def mockProcessRequest(obj, inc=1): | |||
| assert sent == 3 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason='get rid of registry pool') | |||
There was a problem hiding this comment.
We can not skip this test, it's needed.
|
|
||
|
|
||
| # noinspection PyIncorrectDocstring | ||
| @pytest.mark.skip(reason='get rid of registry pool') | ||
| def testConnectWithoutKeySharingFails(tdir_for_func, tconf_for_func): |
There was a problem hiding this comment.
We can not skip this test, it's needed.
ashcherbakov
approved these changes
Apr 17, 2018
lovesh
pushed a commit
to evernym/indy-plenum
that referenced
this pull request
May 3, 2018
* Get rid of RegistryPoolManager Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * Removal of nodeRegistry param Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * fixes Signed-off-by: ArtObr <artemobruchnikov@gmail.com> * fix Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArtObr artemobruchnikov@gmail.com