INDY-1259: fix typo. #615
Merged
INDY-1259: fix typo. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2018 14:54
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
Added check in request_CPs_if_needed() function. More research needed to determine appropriate time to unschedule it. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
dsurnin
approved these changes
Apr 5, 2018
…iew(). Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
dsurnin
approved these changes
Apr 5, 2018
lampkin-diet
approved these changes
Apr 6, 2018
aigoncharov
approved these changes
Apr 6, 2018
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
* INDY-1259: fix typo. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com> * Add check that we have at least one non-null received CP. Added check in request_CPs_if_needed() function. More research needed to determine appropriate time to unschedule it. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com> * Add check that viewno is presented in primaryNames in is_primary_in_view(). Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
* INDY-1259: fix typo. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com> * Add check that we have at least one non-null received CP. Added check in request_CPs_if_needed() function. More research needed to determine appropriate time to unschedule it. Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com> * Add check that viewno is presented in primaryNames in is_primary_in_view(). Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Shilov sergey.shilov@dsr-company.com