Patricia trie prefix proof support #694
Conversation
Merge latest
Merge upstream changes
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Pull upstream changes
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Pull upstream
Pull upstream
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
state/trie/pruning_trie.py
Outdated
| part = key_prfx | ||
|
|
||
| if node_type == NODE_TYPE_LEAF: | ||
| if starts_with(full, part): |
There was a problem hiding this comment.
If this is a LEAF and len(key_prfx) > len(curr_key) and curr_key is a part of key_prfx, then we will return this node. But should we return BLANK_NODE in this case?
| @@ -389,6 +387,49 @@ def _get(self, node, key): | |||
| else: | |||
| return BLANK_NODE | |||
|
|
|||
| def _get_last_node_for_prfx(self, node, key_prfx): | |||
There was a problem hiding this comment.
Please add unit tests for this method
state/trie/pruning_trie.py
Outdated
| proof.pop() | ||
| return o | ||
|
|
||
| def produce_spv_proof_for_key_prfx(self, key_prfx, root=None): |
There was a problem hiding this comment.
So, we are returning state proof for the common part (root till prefix) plus sub-proofs for all prefix's sub-nodes.
But the method name may be a bit confusing since it looks like we return just a common proof (from root till prefix).
Please add the comment for the method. Also maybe we can rename it to produce_spv_proof_for_key_prfx_subnodes?
| try: | ||
| new_trie.root_hash = root | ||
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
It's not good to print exception here. Maybe throw some exception that verification failed?
There was a problem hiding this comment.
I am following the same pattern as is present in similar methods
| add_prefix_nodes_and_verify(state, prefix) | ||
|
|
||
|
|
||
| def test_state_proof_for_key_prefix_4(state): |
There was a problem hiding this comment.
Please add a negative test case where verification fails
There was a problem hiding this comment.
This method calls an underlying method. The negative test cases are present for the underlying method in test_proof_multiple_prefix_nodes
Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
No description provided.