INDY-1304: Added tests that show problems with current view change [test #3] #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…ficate Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…ficate.py Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…t_prepared_certificate.py Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Changes: - added node with advancing node. View change start in ordering and one node break due to advance. Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
| sdk_wallet_client) | ||
|
|
||
|
|
||
| def delay_commits_for_all_except_one_node(nodes, nodes_without_one_stashers, |
There was a problem hiding this comment.
I think it's better to call the method do_view_change_with_delayed_commits_on_all_but_one
…ut_one name Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
test this please |
2 similar comments
|
test this please |
|
test this please |
| nodes_stashers = [n.nodeIbStasher for n in txnPoolNodeSet | ||
| if n != txnPoolNodeSet[-1]] | ||
| for _ in range(2): | ||
| do_view_change_with_delayed_commits_on_all_but_one(txnPoolNodeSet, |
There was a problem hiding this comment.
What assertion do we check here to fail? Is it that we can not send new requests anymore (consensus is lost)?
There was a problem hiding this comment.
We check that 2 random requests will execute successful and we will receive reply. Now this test has assertion error in the last ordered() because except_node can't order new transaction.
ashcherbakov
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that show problems with current view change.
#3
Test case:
Expected result with correct view change: transactions should be ordered normally
Expected result with current view change: node X can't finish second transaction