INDY-1329: Removal of previous stashed checkpoints #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new method getNodesServices (hyperledger#506)
- Added removal of previous stashed received checkpoints on own checkpoint stabilization. - Rolled back the recent changes in the garbage collection. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
plenum/server/replica.py
Outdated
| @@ -2429,7 +2430,8 @@ def caught_up_till_3pc(self, last_caught_up_3PC): | |||
| self._remove_till_caught_up_3pc(last_caught_up_3PC) | |||
| self._remove_ordered_from_queue(last_caught_up_3PC) | |||
| self.checkpoints.clear() | |||
| self._remove_current_view_stashed_checkpoints(last_caught_up_3PC) | |||
| if last_caught_up_3PC[0] == self.viewNo: | |||
There was a problem hiding this comment.
What if haven'e yet ordered anything in this view and last_ordered points to the previous view?
There was a problem hiding this comment.
This means that no stashed received checkpoints from this view must be removed. So we will not get into this if branch.
Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
ashcherbakov
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_second_checkpoint_after_catchup_can_be_stabilizedto verify this logic.